From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ml1Ul-0005XH-6X for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:16:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ml1Ug-0005OA-Ki for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:16:30 -0400 Received: from [199.232.76.173] (port=60470 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ml1Ug-0005Nx-GZ for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:16:26 -0400 Received: from mail-qy0-f191.google.com ([209.85.221.191]:40870) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ml1Ug-0002Yr-8K for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:16:26 -0400 Received: by qyk29 with SMTP id 29so2556283qyk.16 for ; Tue, 08 Sep 2009 07:16:25 -0700 (PDT) Message-ID: <4AA66730.7040901@codemonkey.ws> Date: Tue, 08 Sep 2009 09:16:16 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/2] port over extboot from kvm References: <1252401463-3249-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1252401463-3249-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann wrote: > $subject says pretty much everything. > > extboot.[cS] are a straight copy from the kvm tree. The windup in vl,c > and hw/pc.c is done slightly different, I've added a function to lookup > the boot drive instead of adding a new global variable. > I think the function here is high even if the implementation is ugly. In the past, Paul strongly objected to this. Paul, care to comment? Regards, Anthony Liguori