From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ml1si-0004Hl-Ko for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:41:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ml1sd-0004D2-Kk for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:41:15 -0400 Received: from [199.232.76.173] (port=56454 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ml1sd-0004Cs-HF for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:41:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63820) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ml1sd-0006pg-2r for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:41:11 -0400 Message-ID: <4AA66D00.3010909@redhat.com> Date: Tue, 08 Sep 2009 16:41:04 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1252055670-26958-1-git-send-email-amit.shah@redhat.com> <4AA66543.4000804@codemonkey.ws> In-Reply-To: <4AA66543.4000804@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] virtio-console: Have a static instance of virtconsole List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Amit Shah , qemu-devel@nongnu.org On 09/08/09 16:08, Anthony Liguori wrote: >> Currently the VirtIOConsole struct is allocated from the call >> to virtio_common_init, also doing an UP_CAST implicitly. > Maybe we ought to treat virtio-console like a bus? Do you have any > suggestions Gerd? i.e. the virtio-console pci devices provides some virtual qdev bus (say vmch), then each port is modeled as separate qdev device for that bus? I think that handles it pretty nicely. cheers, Gerd