[Qemu-devel] Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

[Qemu-devel] Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

[Avi Kivity]

On 09/04/2009 05:43 PM, Anthony Liguori wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> Rebased version of Anthony's patch: Allow to specify more than one
> monitor terminal via the -monitor command line switch. This is
> particularly useful when libvirt or some other management tool already
> occupies the primary monitor but you need another one for debugging.
> The current clumsy workaround is to multiplex such additional terminals
> over a qemu character device (e.g. -serial mon:<device>).
>
>    

This (as merged into kvm-next) breaks autotest.  Autotest starts 
qemu-kvm with -monitor unix:/tmp/blah,server,nowait; with this patch it 
no longer opens the socket (as seen with lsof).  I haven't yet found out 
why.

-- 
error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

[Jan Kiszka]

Avi Kivity wrote:
> On 09/04/2009 05:43 PM, Anthony Liguori wrote:
>> From: Jan Kiszka<jan.kiszka@siemens.com>
>>
>> Rebased version of Anthony's patch: Allow to specify more than one
>> monitor terminal via the -monitor command line switch. This is
>> particularly useful when libvirt or some other management tool already
>> occupies the primary monitor but you need another one for debugging.
>> The current clumsy workaround is to multiplex such additional terminals
>> over a qemu character device (e.g. -serial mon:<device>).
>>
>>    
> 
> This (as merged into kvm-next) breaks autotest.  Autotest starts 
> qemu-kvm with -monitor unix:/tmp/blah,server,nowait; with this patch it 
> no longer opens the socket (as seen with lsof).  I haven't yet found out 
> why.

Ok, will have a look.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

[Qemu-devel] Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

[Avi Kivity]

On 09/09/2009 02:32 PM, Jan Kiszka wrote:
>
>> This (as merged into kvm-next) breaks autotest.  Autotest starts
>> qemu-kvm with -monitor unix:/tmp/blah,server,nowait; with this patch it
>> no longer opens the socket (as seen with lsof).  I haven't yet found out
>> why.
>>      
> Ok, will have a look.
>
>    

I think it's a merge error, not a but in the commit itself.

-- 
error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

[Avi Kivity]

On 09/09/2009 02:42 PM, Avi Kivity wrote:
> On 09/09/2009 02:32 PM, Jan Kiszka wrote:
>>
>>> This (as merged into kvm-next) breaks autotest.  Autotest starts
>>> qemu-kvm with -monitor unix:/tmp/blah,server,nowait; with this patch it
>>> no longer opens the socket (as seen with lsof).  I haven't yet found 
>>> out
>>> why.
>> Ok, will have a look.
>>
>
> I think it's a merge error, not a but in the commit itself.
>

It is (totally unrelated to monitors, except that it was introduced when 
I merged that commit); fixed.

-- 
error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

[Jan Kiszka]

Avi Kivity wrote:
> On 09/09/2009 02:42 PM, Avi Kivity wrote:
>> On 09/09/2009 02:32 PM, Jan Kiszka wrote:
>>>> This (as merged into kvm-next) breaks autotest.  Autotest starts
>>>> qemu-kvm with -monitor unix:/tmp/blah,server,nowait; with this patch it
>>>> no longer opens the socket (as seen with lsof).  I haven't yet found 
>>>> out
>>>> why.
>>> Ok, will have a look.
>>>
>> I think it's a merge error, not a but in the commit itself.
>>
> 
> It is (totally unrelated to monitors, except that it was introduced when 
> I merged that commit); fixed.

Fine, tasks-- :)

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux