From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MlQDl-0001ZC-6M
	for qemu-devel@nongnu.org; Wed, 09 Sep 2009 12:40:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MlQDg-0001X7-ES
	for qemu-devel@nongnu.org; Wed, 09 Sep 2009 12:40:36 -0400
Received: from [199.232.76.173] (port=42108 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MlQDg-0001Wy-0B
	for qemu-devel@nongnu.org; Wed, 09 Sep 2009 12:40:32 -0400
Received: from mail-qy0-f195.google.com ([209.85.221.195]:52959)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1MlQDe-0000CS-Bs
	for qemu-devel@nongnu.org; Wed, 09 Sep 2009 12:40:31 -0400
Received: by qyk33 with SMTP id 33so3696314qyk.18
	for <qemu-devel@nongnu.org>; Wed, 09 Sep 2009 09:40:27 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4AA7DA79.4050100@gnu.org>
Date: Wed, 09 Sep 2009 18:40:25 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <200909091542.AA00091@YOUR-BD18D6DD63.m1.interq.or.jp>
In-Reply-To: <200909091542.AA00091@YOUR-BD18D6DD63.m1.interq.or.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 08/14] i8259: support NEC PC-9821 family
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?5q2m55SwIOS/iuS5nw==?= <t-takeda@m1.interq.or.jp>
Cc: qemu-devel <qemu-devel@nongnu.org>


> +static int irq_from_slave;

It would be better to put it in struct PicState2.  Since you are at it, 
the usual name for this is "cascade IRQ" (so irq_cascade).

Paolo