From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MlT4Q-00006Q-Av
	for qemu-devel@nongnu.org; Wed, 09 Sep 2009 15:43:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MlT4L-0008VX-NM
	for qemu-devel@nongnu.org; Wed, 09 Sep 2009 15:43:09 -0400
Received: from [199.232.76.173] (port=44687 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MlT4L-0008VU-I9
	for qemu-devel@nongnu.org; Wed, 09 Sep 2009 15:43:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55377)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MlT4L-0007bO-3V
	for qemu-devel@nongnu.org; Wed, 09 Sep 2009 15:43:05 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n89Jh33w002841
	for <qemu-devel@nongnu.org>; Wed, 9 Sep 2009 15:43:03 -0400
Message-ID: <4AA80544.3000308@redhat.com>
Date: Wed, 09 Sep 2009 21:43:00 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1252507547-11398-1-git-send-email-kraxel@redhat.com>
	<1252507547-11398-13-git-send-email-kraxel@redhat.com>
In-Reply-To: <1252507547-11398-13-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 12/12] qdev/isa: convert real time clock
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

> --- a/hw/mc146818rtc.c
> +++ b/hw/mc146818rtc.c
> @@ -63,10 +63,11 @@
>   #define REG_C_AF   0x20
>
>   struct RTCState {
> +    ISADevice dev;
>       uint8_t cmos_data[128];
>       uint8_t cmos_index;
>       struct tm current_tm;
> -    int base_year;
> +    uint32_t base_year;

Self-NACK.  This sign change breaks some math and makes my VMs 
time-travel to 2005 ...

cheers,
   Gerd