From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MlTRo-0007wY-07 for qemu-devel@nongnu.org; Wed, 09 Sep 2009 16:07:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MlTRj-0007uF-5v for qemu-devel@nongnu.org; Wed, 09 Sep 2009 16:07:19 -0400 Received: from [199.232.76.173] (port=52537 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlTRj-0007u8-2K for qemu-devel@nongnu.org; Wed, 09 Sep 2009 16:07:15 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:46198) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MlTRi-0004Ck-B2 for qemu-devel@nongnu.org; Wed, 09 Sep 2009 16:07:14 -0400 Message-ID: <4AA80970.90000@web.de> Date: Wed, 09 Sep 2009 22:00:48 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20090909151111.26816.49862.stgit@mchn012c.ww002.siemens.net> <4AA7CC66.5060008@us.ibm.com> <4AA7D6AC.7090101@siemens.com> <4AA7ECF8.6040504@us.ibm.com> In-Reply-To: <4AA7ECF8.6040504@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8ABFC791709B28A26941B818" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 0/5] Refactor and enhance RTC configuration List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , Glauber Costa , Dor Laor , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8ABFC791709B28A26941B818 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > Jan Kiszka wrote: >> Anthony Liguori wrote: >> =20 >>> You get most of this pretty cheaply with qdev conversion. If you giv= e >>> the rtc a default id, you can tweak all of the properties with the -s= et >>> command line option. It also provides a mechanism to change the defa= ult >>> properties between machine types/versions which is ideal as we can >>> introduce a kvm-specific machine type where we enable some of these >>> things by default. >>> >>> =20 >> >> Hmm, the refactoring of the old command line switches to -rtc is, if I= >> understand qdev and -set correctly, widely orthogonal. >=20 > No, it isn't. To introduce -rtc properly, you should use QemuOpts. We= > shouldn't be introducing new options that don't conform to QemuOpts > syntax and the best way to do that is to just use QemuOpts. Yes, QemuOpts is a must-have for -rtc. So you agree to introduce -rtc (in addition to the qdev-based configuration, of course)? >=20 > To communicate the QemuOpts to the rtc, I think the easiest approach is= > to convert rtc to qdev and reuse the -device logic. Otherwise, you hav= e > to use statics or add new parameters to the machine init. Agreed. And Gerd obviously already did that work for me. :) >=20 >> Or is the policy >> now to freeze all command line switches in favor of the -device and >> -set?. >=20 > As much as possible, yes, I think this is the reasonable thing to do. >=20 >> However, I will look into qdev conversion of the PC RTC. >> >> Besides the interface thing, I'm also interesting in comments on the >> other core idea, the selectable RTC base clock. Do we want this knob? = Do >> we want host_clock unconditionally? Or should the other RTC that >> currently use the host time already also gain vm_clock support over th= e >> time? >> =20 > Hard to say. Doesn't the rtc keep track of wallclock time even on powe= r > off? I think using host_clock unconditionally does actually make sense= =2E >=20 Moreover, quite a few (of not all?) other RTCs use the host time already. Well, I would be happy to avoid that 'clock' knob. So if there are no concerns, I will unconditionally switch MC146818 to host_clock. Jan --------------enig8ABFC791709B28A26941B818 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkqoCXAACgkQniDOoMHTA+lQ5wCeN3lck97XFNcOn/PPMpVskonu 3ngAnREFiX+LlB9t53VLzcLxrLSIIM3N =ZlOb -----END PGP SIGNATURE----- --------------enig8ABFC791709B28A26941B818--