From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mli4U-00071Z-Du for qemu-devel@nongnu.org; Thu, 10 Sep 2009 07:44:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mli4O-0006vi-Eh for qemu-devel@nongnu.org; Thu, 10 Sep 2009 07:44:13 -0400 Received: from [199.232.76.173] (port=39993 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mli4O-0006vd-7W for qemu-devel@nongnu.org; Thu, 10 Sep 2009 07:44:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30965) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mli4N-0005WG-MV for qemu-devel@nongnu.org; Thu, 10 Sep 2009 07:44:07 -0400 Message-ID: <4AA8E684.7060500@redhat.com> Date: Thu, 10 Sep 2009 14:44:04 +0300 From: Avi Kivity MIME-Version: 1.0 References: <200909092236.n89MaDVc020267@d01av01.pok.ibm.com> In-Reply-To: <200909092236.n89MaDVc020267@d01av01.pok.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 733318e] don't call cpu_sychronize_state from reset handlers List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: Anthony Liguori , qemu-devel On 09/10/2009 01:37 AM, Anthony Liguori wrote: > From: Glauber Costa > > Doing this will make the vcpu ioctl be issued from the I/O thread, instead > of cpu thread. The correct behaviour is to call it from within the cpu thread, > as soon as we are ready to go. > > This commit, when merged into qemu-kvm, breaks reboot and system_reset. I haven't checked upstream qemu (probably needs iothread enabled to have an effect). -- error compiling committee.c: too many arguments to function