From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Amit Shah <amit.shah@redhat.com>,
Bernhard Kauer <kauer@os.inf.tu-dresden.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained?
Date: Thu, 10 Sep 2009 17:38:55 +0300 [thread overview]
Message-ID: <4AA90F7F.2030709@redhat.com> (raw)
In-Reply-To: <4AA90592.7080100@codemonkey.ws>
On 09/10/2009 04:56 PM, Anthony Liguori wrote:
>
> The problem is patch volume. We often see hundreds of patches a day.
> If typing a mail for each patch takes 2 minutes, that's potentially
> hours spent just on sending these mails.
>
You exaggerate. The average rate is 13 patches per calendar day. The
bulk of the patches are in patchsets which can be acked as a set, not
once per patch.
> What I really need is some way to automatically generate these
> notifications. It's pretty easy to send a mail when a patch enters
> the queue but it's more difficult to send a mail when a patch is
> removed from the queue via a rebase. Often times, I remove patches
> from the queue simply because I'm not the right path for the patches
> to be committed from (like linux-user).
I think more per-patch attention is needed, not less, for example see
this commit:
commit e09a5267adf0af25b55d2abaf06e288b2d9537ea
Author: Dustin Kirkland <kirkland@canonical.com>
Date: Thu Sep 3 12:31:33 2009 -0500
qemu-kvm: fix segfault when running kvm without /dev/kvm, falling
back to non-accelerated mode
qemu-kvm: fix segfault when running kvm without /dev/kvm, falling back
to non-accelerated mode
We're seeing segfaults on systems without access to /dev/kvm. It
looks like the global kvm_allowed is being set just a little too late
in vl.c. This patch moves the kvm initialization a bit higher in the
vl.c main, just after options processing, and solves the segfaults.
We're carrying this patch in Ubuntu 9.10 Alpha. Please apply
upstream, or advise if and why this might not be the optimal solution.
Signed-off-by: Dustin Kirkland <kirkland@canonical.com>
Move the kvm_init() call a bit higher to fix a segfault when
/dev/kvm is not available. The kvm_allowed global needs
to be set correctly a little earlier.
Signed-off-by: Dustin Kirkland <kirkland@canonical.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
There are many examples like this in the tree which is a pity. Others
include parts of an email conversation. I'd like history to look better
than this.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-09-10 14:39 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 7:49 [Qemu-devel] [PATCH] [RESEND] RTC polling mode broken Bernhard Kauer
2009-09-09 12:18 ` [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained? Bernhard Kauer
2009-09-09 12:23 ` Amit Shah
2009-09-09 12:58 ` Bernhard Kauer
2009-09-09 12:25 ` Kevin Wolf
2009-09-09 13:00 ` Anthony Liguori
2009-09-09 13:26 ` Gleb Natapov
2009-09-09 13:45 ` Anthony Liguori
2009-09-09 14:31 ` Avi Kivity
2009-09-09 13:34 ` Bernhard Kauer
2009-09-10 7:03 ` Amit Shah
2009-09-10 7:56 ` Reimar Döffinger
2009-09-10 10:08 ` Amit Shah
2009-09-10 11:47 ` Luiz Capitulino
2009-09-10 12:01 ` [Qemu-devel] QEMU patch management Amit Shah
2009-09-10 12:29 ` [Qemu-devel] " Luiz Capitulino
2009-09-10 12:51 ` Reimar Döffinger
2009-09-10 13:11 ` Luiz Capitulino
2009-09-10 17:24 ` Reimar Döffinger
2009-09-10 13:58 ` [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained? Anthony Liguori
2009-09-10 13:56 ` Anthony Liguori
2009-09-10 14:04 ` Amit Shah
2009-09-10 14:12 ` Anthony Liguori
2009-09-10 15:15 ` Amit Shah
2009-09-10 14:38 ` Avi Kivity [this message]
2009-09-10 15:54 ` Anthony Liguori
2009-09-10 16:09 ` Avi Kivity
2009-09-10 16:22 ` Anthony Liguori
2009-09-10 16:35 ` Avi Kivity
2009-09-10 16:38 ` Anthony Liguori
2009-09-10 16:46 ` Avi Kivity
2009-09-10 17:19 ` Reimar Döffinger
2009-09-11 12:39 ` Amit Shah
2009-09-12 5:55 ` Blue Swirl
2009-09-13 15:44 ` Avi Kivity
2009-09-13 16:30 ` Blue Swirl
2009-09-11 7:06 ` Gerd Hoffmann
2009-09-10 18:29 ` Mark McLoughlin
2009-09-10 18:40 ` Avi Kivity
2009-09-10 19:31 ` Anthony Liguori
2009-09-13 15:49 ` Avi Kivity
2009-09-10 20:36 ` Mark McLoughlin
2009-09-13 16:19 ` Avi Kivity
2009-09-14 7:49 ` Mark McLoughlin
2009-09-14 7:59 ` Avi Kivity
2009-09-10 18:59 ` Reimar Döffinger
2009-09-10 16:05 ` Anthony Liguori
2009-09-10 16:14 ` Avi Kivity
2009-09-11 9:16 ` [Qemu-devel] commit e09a5267 (was: [PATCH] [RESEND2] Qemu unmaintained?) Jan Kiszka
2009-09-11 12:56 ` [Qemu-devel] Re: commit e09a5267 Anthony Liguori
2009-09-11 13:04 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA90F7F.2030709@redhat.com \
--to=avi@redhat.com \
--cc=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kauer@os.inf.tu-dresden.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).