From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MlmCn-0001UF-Oj for qemu-devel@nongnu.org; Thu, 10 Sep 2009 12:09:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MlmCe-0001JE-3j for qemu-devel@nongnu.org; Thu, 10 Sep 2009 12:09:01 -0400 Received: from [199.232.76.173] (port=58580 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlmCd-0001Il-Pc for qemu-devel@nongnu.org; Thu, 10 Sep 2009 12:08:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45708) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MlmCd-0006qk-5s for qemu-devel@nongnu.org; Thu, 10 Sep 2009 12:08:55 -0400 Message-ID: <4AA924AE.8060807@redhat.com> Date: Thu, 10 Sep 2009 19:09:18 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained? References: <20090902074905.GB25711@chrom.inf.tu-dresden.de> <20090909121817.GA21997@chrom.inf.tu-dresden.de> <4AA7A6EC.10907@codemonkey.ws> <20090910070336.GD3351@amit-x200.redhat.com> <4AA90592.7080100@codemonkey.ws> <4AA90F7F.2030709@redhat.com> <4AA92122.3050103@codemonkey.ws> In-Reply-To: <4AA92122.3050103@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Amit Shah , Bernhard Kauer , qemu-devel@nongnu.org On 09/10/2009 06:54 PM, Anthony Liguori wrote: > Avi Kivity wrote: >> On 09/10/2009 04:56 PM, Anthony Liguori wrote: >>> >>> The problem is patch volume. We often see hundreds of patches a >>> day. If typing a mail for each patch takes 2 minutes, that's >>> potentially hours spent just on sending these mails. >>> >> >> You exaggerate. The average rate is 13 patches per calendar day. > > On list or committed? There are a lot more on list than 13.. You certainly shouldn't ack patches you don't commit! > >> commit e09a5267adf0af25b55d2abaf06e288b2d9537ea >> Author: Dustin Kirkland >> Date: Thu Sep 3 12:31:33 2009 -0500 >> >> qemu-kvm: fix segfault when running kvm without /dev/kvm, falling >> back to non-accelerated mode >> >> qemu-kvm: fix segfault when running kvm without /dev/kvm, falling >> back >> to non-accelerated mode >> >> We're seeing segfaults on systems without access to /dev/kvm. It >> looks like the global kvm_allowed is being set just a little too >> late >> in vl.c. This patch moves the kvm initialization a bit higher in >> the >> vl.c main, just after options processing, and solves the segfaults. >> We're carrying this patch in Ubuntu 9.10 Alpha. Please apply >> upstream, or advise if and why this might not be the optimal >> solution. >> >> Signed-off-by: Dustin Kirkland >> >> Move the kvm_init() call a bit higher to fix a segfault when >> /dev/kvm is not available. The kvm_allowed global needs >> to be set correctly a little earlier. >> >> Signed-off-by: Dustin Kirkland >> Signed-off-by: Anthony Liguori >> >> There are many examples like this in the tree which is a pity. >> Others include parts of an email conversation. I'd like history to >> look better than this. > > This is goofy and is caused by improper patch submission. But when > people quote email threads in a commit message, I don't remove them. > It don't see it as a problem. From long experience, most commit messages need to be edited. People rarely write commit messages that can be understood a year later, and they don't know how 'git am' works. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.