From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mlnc8-0000JV-FI
	for qemu-devel@nongnu.org; Thu, 10 Sep 2009 13:39:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mlnc3-0000C8-Qf
	for qemu-devel@nongnu.org; Thu, 10 Sep 2009 13:39:19 -0400
Received: from [199.232.76.173] (port=36888 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mlnc3-0000Bt-En
	for qemu-devel@nongnu.org; Thu, 10 Sep 2009 13:39:15 -0400
Received: from mail-qy0-f190.google.com ([209.85.221.190]:46061)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Mlnc3-0001s6-4A
	for qemu-devel@nongnu.org; Thu, 10 Sep 2009 13:39:15 -0400
Received: by qyk28 with SMTP id 28so283520qyk.28
	for <qemu-devel@nongnu.org>; Thu, 10 Sep 2009 10:39:14 -0700 (PDT)
Message-ID: <4AA939B3.6000103@codemonkey.ws>
Date: Thu, 10 Sep 2009 12:38:59 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable.
	Create get_ticks_per_sec() function
References: <cover.1252543871.git.quintela@redhat.com>	<e903a9c54c3a05c835b4c13c8995e58f0f5d84f6.1252543871.git.quintela@redhat.com>	<Pine.LNX.4.64.0909100520290.6815@linmac.oyster.ru>	<m3eiqf4l4z.fsf@neno.mitica>	<Pine.LNX.4.64.0909100621001.8593@linmac.oyster.ru>	<m34orahhrc.fsf@neno.mitica>
	<Pine.LNX.4.64.0909102058450.3942@linmac.oyster.ru>
In-Reply-To: <Pine.LNX.4.64.0909102058450.3942@linmac.oyster.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

malc wrote:
> My problem with this patch is that it is completely pointless, touches
> a gob of places and the fact that you apparently never seen what a
> function call entails on PPC64 (any ABI).
>   

But there is nothing to suggest this variable is every in the fast path 
so any overhead argument is unfounded.

More importantly, using a function to access this variable gives us the 
ability to change how the behavior is implemented without touching a gob 
of places.

This is refactoring 101 and unless there is some concrete objection, I 
don't see what's wrong with it.

Regards,

Anthony Liguori