From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mm0ub-0005l4-CD
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:51:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mm0uU-0005h8-Mn
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:51:14 -0400
Received: from [199.232.76.173] (port=38866 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mm0uU-0005gy-JA
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:51:10 -0400
Received: from mx20.gnu.org ([199.232.41.8]:2449)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1Mm0uT-0003Kd-PO
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:51:10 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mm0uS-0003Xs-Km
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:51:08 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8B7p7aW029508
	for <qemu-devel@nongnu.org>; Fri, 11 Sep 2009 03:51:07 -0400
Received: from zweiblum.home.kraxel.org (vpn1-5-42.ams2.redhat.com
	[10.36.5.42])
	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id n8B7p2LT025741
	for <qemu-devel@nongnu.org>; Fri, 11 Sep 2009 03:51:05 -0400
Message-ID: <4AAA0164.5060702@redhat.com>
Date: Fri, 11 Sep 2009 09:51:00 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 07/19] Never overwrite a QemuOpt
References: <1252595941-15196-1-git-send-email-markmc@redhat.com>
	<1252595941-15196-8-git-send-email-markmc@redhat.com>
In-Reply-To: <1252595941-15196-8-git-send-email-markmc@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 09/10/09 17:18, Mark McLoughlin wrote:
> Rather than overwriting a QemuOpt, just add a new one to the tail and
> always do a reverse search for parameters to preserve the same
> behaviour. We use this order so that foreach() iterates over the opts
> in their original order.

I think we should simply add a flag to QemuOptsDesc saying 'this can 
have multiple instances' instead of doing these reverse search tricks to 
maintain backward compatibility.

cheers,
   Gerd