From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mm10o-0008Lt-Fd
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:57:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mm10k-0008KW-Td
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:57:42 -0400
Received: from [199.232.76.173] (port=36686 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mm10k-0008KO-Lv
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:57:38 -0400
Received: from mx20.gnu.org ([199.232.41.8]:2860)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1Mm10k-000452-1r
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:57:38 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mm10j-0003ya-A7
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:57:37 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8B7vZdH013559
	for <qemu-devel@nongnu.org>; Fri, 11 Sep 2009 03:57:35 -0400
Received: from zweiblum.home.kraxel.org (vpn1-5-42.ams2.redhat.com
	[10.36.5.42])
	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id n8B7vPxK025686
	for <qemu-devel@nongnu.org>; Fri, 11 Sep 2009 03:57:29 -0400
Message-ID: <4AAA02E1.1040703@redhat.com>
Date: Fri, 11 Sep 2009 09:57:21 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 09/19] Port -net none and -net nic to QemuOpts
References: <1252595941-15196-1-git-send-email-markmc@redhat.com>
	<1252595941-15196-10-git-send-email-markmc@redhat.com>
In-Reply-To: <1252595941-15196-10-git-send-email-markmc@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

   Hi,

> +#define NET_COMMON_PARAMS_DESC                     \

> +        .name = "name",                            \
> +        .type = QEMU_OPT_STRING,                   \
> +        .help = "identifier for monitor commands", \

QemuOpts has id= which IMHO should be used here instead for consistency 
reasons.  I suspect we have to support name= as well for backward 
compatibility ...

cheers,
   Gerd