From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mm2R5-0005yK-Rz
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 05:28:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mm2R0-0005r8-SO
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 05:28:55 -0400
Received: from [199.232.76.173] (port=59752 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mm2R0-0005qi-LB
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 05:28:50 -0400
Received: from thoth.sbs.de ([192.35.17.2]:20204)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1Mm2R0-0002r8-7v
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 05:28:50 -0400
Message-ID: <4AAA185F.4020104@siemens.com>
Date: Fri, 11 Sep 2009 11:29:03 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1252507547-11398-1-git-send-email-kraxel@redhat.com>	<1252507547-11398-13-git-send-email-kraxel@redhat.com>
	<4AA80544.3000308@redhat.com>
In-Reply-To: <4AA80544.3000308@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 12/12] qdev/isa: convert real time clock
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Gerd Hoffmann wrote:
>> --- a/hw/mc146818rtc.c
>> +++ b/hw/mc146818rtc.c
>> @@ -63,10 +63,11 @@
>>   #define REG_C_AF   0x20
>>
>>   struct RTCState {
>> +    ISADevice dev;
>>       uint8_t cmos_data[128];
>>       uint8_t cmos_index;
>>       struct tm current_tm;
>> -    int base_year;
>> +    uint32_t base_year;
> 
> Self-NACK.  This sign change breaks some math and makes my VMs
> time-travel to 2005 ...
> 

I thought you retracted this patch, but now I find it in master. Is
there fix in the queue?

To err is human, and the more patches are committed, the more errors can
happen. Still, my impression is that the current rate could be lower.
Gerd, maybe you should have CC'ed Anthony for the NACK.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux