From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mm6sQ-0001jm-PU
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 10:13:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mm6sM-0001gn-3g
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 10:13:26 -0400
Received: from [199.232.76.173] (port=55575 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mm6sL-0001gb-Ro
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 10:13:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34220)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mm6sL-000166-8e
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 10:13:21 -0400
Message-ID: <4AAA5AFD.1020509@redhat.com>
Date: Fri, 11 Sep 2009 16:13:17 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1252672351-12937-1-git-send-email-kraxel@redhat.com>	<1252672351-12937-6-git-send-email-kraxel@redhat.com>
	<m3bplh8u13.fsf@neno.mitica>
In-Reply-To: <m3bplh8u13.fsf@neno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 5/8] ide/pci: convert to qdev.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org

On 09/11/09 15:56, Juan Quintela wrote:
> Gerd Hoffmann<kraxel@redhat.com>  wrote:
>> With this patch applied ide drives (when attached to a pci adapter) can
>> be created via -device, like this:
>> -    IDEBus bus[2];
>> +    IDEBus *bus[2];
>
> You change a nice static array for a pointer to one array.

I can't spot a pointer here.

> VMState is happier with embedded arrays and not pointers to arrays.

There also is no pointer to an array.  It is an embedded array holding 
pointers.

cheers,
   Gerd