From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mm77Y-0007S7-LV
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 10:29:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mm77S-0007HV-1a
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 10:29:02 -0400
Received: from [199.232.76.173] (port=49804 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mm77R-0007Gv-Ig
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 10:28:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26978)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mm77Q-0004UQ-VA
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 10:28:57 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8BESu3a014686
	for <qemu-devel@nongnu.org>; Fri, 11 Sep 2009 10:28:56 -0400
Message-ID: <4AAA5EA5.7010205@redhat.com>
Date: Fri, 11 Sep 2009 16:28:53 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/8] qdev/pci: add pci_create_noinit()
References: <1252672351-12937-1-git-send-email-kraxel@redhat.com>	<1252672351-12937-2-git-send-email-kraxel@redhat.com>
	<87ws45d0vs.fsf@pike.pond.sub.org>
In-Reply-To: <87ws45d0vs.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

>> -PCIDevice *pci_create_simple(PCIBus *bus, int devfn, const char *name)
>> +PCIDevice *pci_create_noinit(PCIBus *bus, int devfn, const char *name)
>>   {
>>       DeviceState *dev;
>>
>>       dev = qdev_create(&bus->qbus, name);
>>       qdev_prop_set_uint32(dev, "addr", devfn);
>> -    qdev_init(dev);
>> +    return DO_UPCAST(PCIDevice, qdev, dev);
>> +}
>
> Okay, this is qdev_create() specialized for PCI.  What about calling it
> just pci_create()?

pci_create() should go away once it has no more users.  It doesn't 
accept a pcibus parameter as it should.

cheers,
   Gerd