From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mm7ck-0005M8-60
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:01:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mm7cf-0005Ha-KU
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:01:17 -0400
Received: from [199.232.76.173] (port=48181 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mm7cf-0005HT-Cp
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:01:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57041)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mm7ce-0001zt-RT
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:01:13 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8BF1CfM020502
	for <qemu-devel@nongnu.org>; Fri, 11 Sep 2009 11:01:12 -0400
Message-ID: <4AAA6635.3060004@redhat.com>
Date: Fri, 11 Sep 2009 17:01:09 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/8] ide/qdev: add ide bus.
References: <1252672351-12937-1-git-send-email-kraxel@redhat.com>	<1252672351-12937-5-git-send-email-kraxel@redhat.com>
	<87fxatcz1s.fsf@pike.pond.sub.org>
In-Reply-To: <87fxatcz1s.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

>> +    qdev_init(dev);
>
> Callback dev->info is ide_qdev_init(), which can fail, so qdev_init()
> can fail, can't it?

Indeed, will fix.

cheers,
   Gerd