From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mm8CK-0004d8-Bi
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:38:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mm8CH-0004cB-1l
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:38:04 -0400
Received: from [199.232.76.173] (port=41114 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mm8CG-0004c8-M5
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:38:00 -0400
Received: from mail-yx0-f190.google.com ([209.85.210.190]:55067)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Mm8CG-0002ae-D8
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:38:00 -0400
Received: by yxe28 with SMTP id 28so1423489yxe.19
	for <qemu-devel@nongnu.org>; Fri, 11 Sep 2009 08:38:00 -0700 (PDT)
Message-ID: <4AAA6ED6.6080604@codemonkey.ws>
Date: Fri, 11 Sep 2009 10:37:58 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1252543871.git.quintela@redhat.com>
	<9e1839178f7a85d264eee20a07d4aed6e6ddb7b1.1252543871.git.quintela@redhat.com>
	<alpine.DEB.2.00.0909101836390.28497@kaball-desktop>
	<m363bqg0gm.fsf@neno.mitica>
	<alpine.DEB.2.00.0909101848450.28497@kaball-desktop>
	<4AA94403.5020500@codemonkey.ws>
	<alpine.DEB.2.00.0909111500560.2687@kaball-desktop>
	<m31vmd8sj6.fsf@neno.mitica>
	<alpine.DEB.2.00.0909111542580.2687@kaball-desktop>
In-Reply-To: <alpine.DEB.2.00.0909111542580.2687@kaball-desktop>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 03/26] Remove SaveVM v2 support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

Stefano Stabellini wrote:
> No one complained because the people affected by this issue probably
> don't follow qemu development so closely to have realized that their old
> images won't work anymore.
> I do believe that fixing v2 compatibility is important for a large
> number of qemu users (including kvm and xen).
>   

kvm never supported live migration with v2.  As I think I mentioned in 
another note, I don't want to burden the VMState refactoring with 
supporting a format that qemu doesn't support upstream.  That said, if 
you want to add back a version of it that makes use of the new 
infrastructure, I would be willing to take that.

In fact, if you're willing to do the cleanup work along with Juan, we 
can avoid removing it.

> That said, I don't want to fight over this more than necessary, so as
> long as you keep the per device loading functions in C we can maintain
> v2 compatibility downstream if upstream is not interested.
>   

The per device loading functions will be switching to VMState.

Regards,

Anthony Liguori