From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mm8We-0001DE-KM for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:59:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mm8WZ-0001A4-Qm for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:59:03 -0400 Received: from [199.232.76.173] (port=37235 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mm8WZ-00019z-Gm for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:58:59 -0400 Received: from thoth.sbs.de ([192.35.17.2]:24753) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mm8WY-00067r-J1 for qemu-devel@nongnu.org; Fri, 11 Sep 2009 11:58:59 -0400 Message-ID: <4AAA73B2.4090208@siemens.com> Date: Fri, 11 Sep 2009 17:58:42 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4AA939B3.6000103@codemonkey.ws> <4AA978DB.90301@codemonkey.ws> <4AAA6E10.6080308@codemonkey.ws> In-Reply-To: <4AAA6E10.6080308@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Juan Quintela Anthony Liguori wrote: > malc wrote: >> And generalizations are always true. Anyhow, i'm explicitly against the >> patch, so first obtain the express acknowledgment from the leaders, >> otherwise i'll revert it should it go in. >> > > I'm adding the following patch to Juan's series. The result is that > get_ticks_per_sec() should be optimized to a literal value. The result > being that uses of it are faster than they were before (not it should > matter). Perfect! > > I think the result of this patch is that the refactoring is an > undeniable improvement. > > Regards, > > Anthony Liguori > > Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux