From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mm8p9-0003Yb-Ho for qemu-devel@nongnu.org; Fri, 11 Sep 2009 12:18:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mm8p4-0003Ub-Jj for qemu-devel@nongnu.org; Fri, 11 Sep 2009 12:18:10 -0400 Received: from [199.232.76.173] (port=52959 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mm8p4-0003UO-6Y for qemu-devel@nongnu.org; Fri, 11 Sep 2009 12:18:06 -0400 Received: from david.siemens.de ([192.35.17.14]:16578) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mm8p3-0000pD-Q2 for qemu-devel@nongnu.org; Fri, 11 Sep 2009 12:18:06 -0400 Message-ID: <4AAA783A.8040102@siemens.com> Date: Fri, 11 Sep 2009 18:18:02 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1252680092-5208-1-git-send-email-glommer@redhat.com> <4AAA7318.7040106@siemens.com> <20090911161219.GD4489@mothafucka.localdomain> In-Reply-To: <20090911161219.GD4489@mothafucka.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] temporary fix for on_vcpu List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: "aliguori@us.ibm.com" , "qemu-devel@nongnu.org" Glauber Costa wrote: > On Fri, Sep 11, 2009 at 05:56:08PM +0200, Jan Kiszka wrote: >> Glauber Costa wrote: >>> Recent changes made on_vcpu hit the abort() path, even with the IO thread >>> disabled. This is because cpu_single_env is no longer set when we call this >>> function. Although the correct fix is a little bit more complicated that that, >>> the recent thread in which I proposed qemu_queue_work (which fixes that, btw), >>> is likely to go on a quite different direction. >>> >>> So for the benefit of those using guest debugging, I'm proposing this simple >>> fix in the interim. >>> >>> Signed-off-by: Glauber Costa >>> --- >>> kvm-all.c | 4 ++++ >>> 1 files changed, 4 insertions(+), 0 deletions(-) >>> >>> diff --git a/kvm-all.c b/kvm-all.c >>> index df4e849..2c24440 100644 >>> --- a/kvm-all.c >>> +++ b/kvm-all.c >>> @@ -902,11 +902,15 @@ void kvm_setup_guest_memory(void *start, size_t size) >>> #ifdef KVM_CAP_SET_GUEST_DEBUG >>> static void on_vcpu(CPUState *env, void (*func)(void *data), void *data) >>> { >>> +#ifdef CONFIG_IOTHREAD >>> if (env == cpu_single_env) { >>> func(data); >>> return; >>> } >>> abort(); >>> +#else >>> + func(data); >> spaces++ :) But the workaround works. >> >>> +#endif >>> } >>> >>> struct kvm_sw_breakpoint *kvm_find_sw_breakpoint(CPUState *env, >> Unless there is hope to fix kvm in iothread mode soon, we should issue a >> warning or even disable kvm support in that setup. That is particularly >> important for 0.11-stable. > As I said, with the fixes I sent recently, it should work pretty well. You are referring to the workqueue things? Or "do proper cpu_self check" and the corresponding 2/2 (which I do not find in the archives)? Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux