From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mm99A-0003Ot-Nh for qemu-devel@nongnu.org; Fri, 11 Sep 2009 12:38:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mm993-0003Dm-7r for qemu-devel@nongnu.org; Fri, 11 Sep 2009 12:38:51 -0400 Received: from [199.232.76.173] (port=41845 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mm992-0003Cf-Cu for qemu-devel@nongnu.org; Fri, 11 Sep 2009 12:38:44 -0400 Received: from mail-yw0-f203.google.com ([209.85.211.203]:57636) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mm992-0004Et-DF for qemu-devel@nongnu.org; Fri, 11 Sep 2009 12:38:44 -0400 Received: by ywh41 with SMTP id 41so1690475ywh.19 for ; Fri, 11 Sep 2009 09:38:43 -0700 (PDT) Message-ID: <4AAA7D0C.2020200@codemonkey.ws> Date: Fri, 11 Sep 2009 11:38:36 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1252684353-25067-1-git-send-email-amit.shah@redhat.com> <1252684353-25067-2-git-send-email-amit.shah@redhat.com> <1252684353-25067-3-git-send-email-amit.shah@redhat.com> <4AAA7813.1030904@codemonkey.ws> <20090911163410.GA25535@amit-x200.redhat.com> In-Reply-To: <20090911163410.GA25535@amit-x200.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/5] virtio-console: Add support for multiple ports for generic guest-host communication List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu-devel@nongnu.org Amit Shah wrote: > There wasn't any consensus; the discussion just ended abruptly. > At least Gerd and I were in violent agreement. I don't think anyone disagreed. >> If a user does: >> >> qemu -M pc-0.11.0 -virtiocon vc -virtiocon vc >> >> This patch will break that guest. I think the best solution to this is >> > > If there are multiple virtiocon devices specified, the first one will > default to port #0. The second one will error out saying port 0 is > taken. Isn't different from the current behaviour though. > But that's a problem for -M pc-0.11.0. We need to have a way to specify a command line syntax with -M pc-0.11.0 such that the machine created matches what would have been created with qemu-0.11.0. Otherwise, we have no hope of being able to do live migration or save/restore between versions. >> We don't want to add PCI dependency to virtio console. It isn't always >> used on platforms with PCI. >> > > OK; there's a place where I need the qdev pointer from the PCIDevice. > Any other way of obtaining that? > Why do you need the qdev pointer? >> Need to integrate with QemuOpts. >> > > Wondering if it already entered master.. I'll sync up with kraxel if > not. > > Yup, it's been there for a while. >>> + >>> + register_savevm("virtio-console", -1, 2, virtio_console_save, virtio_console_load, s); >>> >>> >> Should integrate with VMState. >> > > I don't think virtio devices have been converted yet. > I think that's next on Juan's list. Regards, Anthony Liguori