qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/5] virtio-console: Add support for multiple ports for generic guest-host communication
Date: Fri, 11 Sep 2009 12:34:13 -0500	[thread overview]
Message-ID: <4AAA8A15.5040307@codemonkey.ws> (raw)
In-Reply-To: <20090911173030.GA27046@amit-x200.redhat.com>

Amit Shah wrote:
> On (Fri) Sep 11 2009 [11:38:36], Anthony Liguori wrote:
>   
>> Amit Shah wrote:
>>     
>>> There wasn't any consensus; the discussion just ended abruptly.
>>>   
>>>       
>> At least Gerd and I were in violent agreement.  I don't think anyone  
>> disagreed.
>>     
>
> So how's suggestion about udev making symlinks based on the ports ids?
>   

That doesn't solve the problem that fqdn solves.  fqdn provides a means 
to avoid having to do centralized port number allocation.

>>  that's a problem for -M pc-0.11.0.  We need to have a way to specify  
>> a command line syntax with -M pc-0.11.0 such that the machine created  
>> matches what would have been created with qemu-0.11.0.  Otherwise, we  
>> have no hope of being able to do live migration or save/restore between  
>> versions.
>>     
>
> I don't actually know if I understand this completely. However, with the
> current behaviour, qemu just exits saying something like too many virtio
> consoles since the current MAX_VIRTIO_CONSOLES is defined to 1.
>   

Oh, that's goofy.  Sorry, I didn't realize that.

>> Why do you need the qdev pointer?
>>     
>
> To init a chardev in the port hotplug case, qdev_init_chardev() needs
> the qdev pointer.
>   

If you converted to a bus, this problem would go away.

>> I think that's next on Juan's list.
>>     
>
> Right; so we'll talk about that.
>
> 		Amit
>   

Regards,

Anthony Liguori

  reply	other threads:[~2009-09-11 17:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 15:52 [Qemu-devel] Multiple ports for virtio-console Amit Shah
2009-09-11 15:52 ` [Qemu-devel] [PATCH 1/5] char: Emit 'OPENED' events on char device open Amit Shah
2009-09-11 15:52   ` [Qemu-devel] [PATCH 2/5] virtio-console: Add support for multiple ports for generic guest-host communication Amit Shah
2009-09-11 15:52     ` [Qemu-devel] [PATCH 3/5] virtio-console: Add a in-qemu api for open/read/write/close ports Amit Shah
2009-09-11 15:52       ` [Qemu-devel] [PATCH 4/5] vnc: add a is_vnc_active() helper Amit Shah
2009-09-11 15:52         ` [Qemu-devel] [PATCH 5/5] vnc: Send / receive guest clipboard if virtio-console connected to clipboard port Amit Shah
2009-09-11 16:17     ` [Qemu-devel] Re: [PATCH 2/5] virtio-console: Add support for multiple ports for generic guest-host communication Anthony Liguori
2009-09-11 16:34       ` Amit Shah
2009-09-11 16:38         ` Anthony Liguori
2009-09-11 17:30           ` Amit Shah
2009-09-11 17:34             ` Anthony Liguori [this message]
2009-09-14  7:48           ` Amit Shah
2009-09-14  7:55             ` Amit Shah
2009-09-14 12:55               ` Anthony Liguori
2009-09-14 12:58                 ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AAA8A15.5040307@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).