From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmA0t-0008Sq-74 for qemu-devel@nongnu.org; Fri, 11 Sep 2009 13:34:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmA0o-0008Q8-OW for qemu-devel@nongnu.org; Fri, 11 Sep 2009 13:34:22 -0400 Received: from [199.232.76.173] (port=58874 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmA0o-0008Q0-H1 for qemu-devel@nongnu.org; Fri, 11 Sep 2009 13:34:18 -0400 Received: from mail-yw0-f203.google.com ([209.85.211.203]:43661) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MmA0o-0006I3-29 for qemu-devel@nongnu.org; Fri, 11 Sep 2009 13:34:18 -0400 Received: by ywh41 with SMTP id 41so1753938ywh.19 for ; Fri, 11 Sep 2009 10:34:16 -0700 (PDT) Message-ID: <4AAA8A15.5040307@codemonkey.ws> Date: Fri, 11 Sep 2009 12:34:13 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1252684353-25067-1-git-send-email-amit.shah@redhat.com> <1252684353-25067-2-git-send-email-amit.shah@redhat.com> <1252684353-25067-3-git-send-email-amit.shah@redhat.com> <4AAA7813.1030904@codemonkey.ws> <20090911163410.GA25535@amit-x200.redhat.com> <4AAA7D0C.2020200@codemonkey.ws> <20090911173030.GA27046@amit-x200.redhat.com> In-Reply-To: <20090911173030.GA27046@amit-x200.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/5] virtio-console: Add support for multiple ports for generic guest-host communication List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu-devel@nongnu.org Amit Shah wrote: > On (Fri) Sep 11 2009 [11:38:36], Anthony Liguori wrote: > >> Amit Shah wrote: >> >>> There wasn't any consensus; the discussion just ended abruptly. >>> >>> >> At least Gerd and I were in violent agreement. I don't think anyone >> disagreed. >> > > So how's suggestion about udev making symlinks based on the ports ids? > That doesn't solve the problem that fqdn solves. fqdn provides a means to avoid having to do centralized port number allocation. >> that's a problem for -M pc-0.11.0. We need to have a way to specify >> a command line syntax with -M pc-0.11.0 such that the machine created >> matches what would have been created with qemu-0.11.0. Otherwise, we >> have no hope of being able to do live migration or save/restore between >> versions. >> > > I don't actually know if I understand this completely. However, with the > current behaviour, qemu just exits saying something like too many virtio > consoles since the current MAX_VIRTIO_CONSOLES is defined to 1. > Oh, that's goofy. Sorry, I didn't realize that. >> Why do you need the qdev pointer? >> > > To init a chardev in the port hotplug case, qdev_init_chardev() needs > the qdev pointer. > If you converted to a bus, this problem would go away. >> I think that's next on Juan's list. >> > > Right; so we'll talk about that. > > Amit > Regards, Anthony Liguori