From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Unlike real hardware, vmport needs access to the CPU [...]
Date: Sat, 12 Sep 2009 16:46:04 +0200 [thread overview]
Message-ID: <4AABB42C.3070103@web.de> (raw)
In-Reply-To: <20090912141128.GA15236@1und1.de>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
=?UTF-8?q?Reimar=20D=C3=B6ffinger?= wrote:
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
> ---
> hw/vmport.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/vmport.c b/hw/vmport.c
> index 884af3f..9a942ee 100644
> --- a/hw/vmport.c
> +++ b/hw/vmport.c
> @@ -25,6 +25,7 @@
> #include "isa.h"
> #include "pc.h"
> #include "sysemu.h"
> +#include "kvm.h"
>
> //#define VMPORT_DEBUG
>
> @@ -58,6 +59,7 @@ static uint32_t vmport_ioport_read(void *opaque, uint32_t addr)
> unsigned char command;
> uint32_t eax;
>
> + cpu_synchronize_state(env);
> eax = env->regs[R_EAX];
> if (eax != VMPORT_MAGIC)
> return eax;
Ack (qemu-kvm carries a similar patch).
But please grant your patches some proper titles.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-09-12 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-12 14:11 [Qemu-devel] [PATCH] Unlike real hardware, vmport needs access to the CPU registers to handle iomem read and writes. So add an explicit cpu_synchronize_state call, otherwise vmmouse can not work with KVM =?UTF-8?q?Reimar=20D=C3=B6ffinger?=
2009-09-12 14:46 ` Jan Kiszka [this message]
2009-09-12 15:34 ` [Qemu-devel] Re: [PATCH] Unlike real hardware, vmport needs access to the CPU [...] Reimar Döffinger
2009-09-12 15:47 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AABB42C.3070103@web.de \
--to=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).