From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmUon-0004mU-SP for qemu-devel@nongnu.org; Sat, 12 Sep 2009 11:47:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmUoj-0004kS-85 for qemu-devel@nongnu.org; Sat, 12 Sep 2009 11:47:17 -0400 Received: from [199.232.76.173] (port=46919 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmUoj-0004kL-1J for qemu-devel@nongnu.org; Sat, 12 Sep 2009 11:47:13 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:52717) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MmUoi-0001Rb-BP for qemu-devel@nongnu.org; Sat, 12 Sep 2009 11:47:12 -0400 Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215]) by fmmailgate02.web.de (Postfix) with ESMTP id 29E7A11E78DF4 for ; Sat, 12 Sep 2009 17:47:11 +0200 (CEST) Received: from [88.65.36.68] (helo=[192.168.1.10]) by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #314) id 1MmUog-0006sq-00 for qemu-devel@nongnu.org; Sat, 12 Sep 2009 17:47:11 +0200 Message-ID: <4AABC278.90004@web.de> Date: Sat, 12 Sep 2009 17:47:04 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] Unlike real hardware, vmport needs access to the CPU [...] References: <20090912141128.GA15236@1und1.de> <4AABB42C.3070103@web.de> <20090912153444.GA8417@1und1.de> In-Reply-To: <20090912153444.GA8417@1und1.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig709B90FF6BD238164AB335BC" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig709B90FF6BD238164AB335BC Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Reimar D=F6ffinger wrote: > On Sat, Sep 12, 2009 at 04:46:04PM +0200, Jan Kiszka wrote: >> =3D?UTF-8?q?Reimar=3D20D=3DC3=3DB6ffinger?=3D wrote: >>> Signed-off-by: Reimar D=F6ffinger >>> --- >>> hw/vmport.c | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/hw/vmport.c b/hw/vmport.c >>> index 884af3f..9a942ee 100644 >>> --- a/hw/vmport.c >>> +++ b/hw/vmport.c >>> @@ -25,6 +25,7 @@ >>> #include "isa.h" >>> #include "pc.h" >>> #include "sysemu.h" >>> +#include "kvm.h" >>> =20 >>> //#define VMPORT_DEBUG >>> =20 >>> @@ -58,6 +59,7 @@ static uint32_t vmport_ioport_read(void *opaque, ui= nt32_t addr) >>> unsigned char command; >>> uint32_t eax; >>> =20 >>> + cpu_synchronize_state(env); >>> eax =3D env->regs[R_EAX]; >>> if (eax !=3D VMPORT_MAGIC) >>> return eax; >> Ack (qemu-kvm carries a similar patch). >=20 > Now that I look at it... yes. > Except that it does not yet have cpu_synchronize_state and thus is brok= en for > vmport_ioport_write, the return value written to EAX is lost. Normally qemu-kvm catches such things when merging from upstream. >=20 >> But please grant your patches some proper titles. >=20 > Sorry, I am still figuring out how to write commit messages that git fo= rmat-patch > handles in a good way (as well as the most sane way to use it in > general). This rule is simple, just write your commit messages in the form Title Description... Moreover, your mail client is configured to inject "Mail-Followup-To" into your postings. This quickly causes troubles. E.g., it suggested my client to send myself a mail when replying to yours. Jan --------------enig709B90FF6BD238164AB335BC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkqrwn0ACgkQniDOoMHTA+l3pwCeOT+0gGLmaMsv7DSgSC3LrU0O 0r4AoIBwXQB6hrjQ1Xf+cr4ngPmATfdP =VSrH -----END PGP SIGNATURE----- --------------enig709B90FF6BD238164AB335BC--