From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mn5IL-0001jd-Vs for qemu-devel@nongnu.org; Mon, 14 Sep 2009 02:44:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mn5IG-0001fl-DW for qemu-devel@nongnu.org; Mon, 14 Sep 2009 02:44:12 -0400 Received: from [199.232.76.173] (port=51903 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mn5IG-0001fi-7r for qemu-devel@nongnu.org; Mon, 14 Sep 2009 02:44:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58257) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mn5IF-0003EJ-Nh for qemu-devel@nongnu.org; Mon, 14 Sep 2009 02:44:08 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8E6i5Ml004663 for ; Mon, 14 Sep 2009 02:44:06 -0400 Message-ID: <4AADE632.6020803@redhat.com> Date: Mon, 14 Sep 2009 08:44:02 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 5/8] ide/pci: convert to qdev. References: <1252672351-12937-1-git-send-email-kraxel@redhat.com> <1252672351-12937-6-git-send-email-kraxel@redhat.com> <87pr9xbj6y.fsf@pike.pond.sub.org> In-Reply-To: <87pr9xbj6y.fsf@pike.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org Hi, >> - pci_conf[0x3d] = 0x01; // interrupt on pin 1 > > Any particular reason for moving this assignment up? Probably just because the patch went through a number of revisions ... cheers, Gerd