Re: [Qemu-devel] [PATCH 0/6] Clean up use of qdev_init()

[Gerd Hoffmann <kraxel@redhat.com>]

On 09/11/09 22:19, Markus Armbruster wrote:
> qdev_init() can fail since commit 81a322d4.  Most callers don't bother
> to check.  This is less serious than it sounds, because they typically
> work with devices for which qdev_init() never fails.  It's still
> unclean.
>
> The last patch makes the compiler warn when the value of qdev_init()
> isn't used.  If that warning triggers after merging this series, more
> unchecked calls have crept in since the base of this series (commit
> 2637c754).  Feel free to ask me for a respin then.
>
> Markus Armbruster (6):
>    Move function definitions out of xilinx.h
>    Make qdev_init() destroy the device on failure
>    Check return value of qdev_init()
>    New qdev_init_nofail()
>    Make isa_create() terminate program on failure
>    Warn if value of qdev_init() isn't checked

Whole series looks good to me, nice cleanup.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd