From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mn79n-0003CW-73
	for qemu-devel@nongnu.org; Mon, 14 Sep 2009 04:43:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mn79i-0003CK-KH
	for qemu-devel@nongnu.org; Mon, 14 Sep 2009 04:43:30 -0400
Received: from [199.232.76.173] (port=57905 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mn79i-0003CH-H3
	for qemu-devel@nongnu.org; Mon, 14 Sep 2009 04:43:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15802)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mn79i-0001gs-2q
	for qemu-devel@nongnu.org; Mon, 14 Sep 2009 04:43:26 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8E8hOSa030116
	for <qemu-devel@nongnu.org>; Mon, 14 Sep 2009 04:43:24 -0400
Received: from zweiblum.home.kraxel.org (vpn2-9-128.ams2.redhat.com
	[10.36.9.128])
	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id n8E8hMUW023201
	for <qemu-devel@nongnu.org>; Mon, 14 Sep 2009 04:43:23 -0400
Message-ID: <4AAE0229.9000201@redhat.com>
Date: Mon, 14 Sep 2009 10:43:21 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/6] Clean up use of qdev_init()
References: <cover.1252699478.git.armbru@redhat.com>
In-Reply-To: <cover.1252699478.git.armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 09/11/09 22:19, Markus Armbruster wrote:
> qdev_init() can fail since commit 81a322d4.  Most callers don't bother
> to check.  This is less serious than it sounds, because they typically
> work with devices for which qdev_init() never fails.  It's still
> unclean.
>
> The last patch makes the compiler warn when the value of qdev_init()
> isn't used.  If that warning triggers after merging this series, more
> unchecked calls have crept in since the base of this series (commit
> 2637c754).  Feel free to ask me for a respin then.
>
> Markus Armbruster (6):
>    Move function definitions out of xilinx.h
>    Make qdev_init() destroy the device on failure
>    Check return value of qdev_init()
>    New qdev_init_nofail()
>    Make isa_create() terminate program on failure
>    Warn if value of qdev_init() isn't checked

Whole series looks good to me, nice cleanup.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd