From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnF2R-0000FK-Fz for qemu-devel@nongnu.org; Mon, 14 Sep 2009 13:08:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnF2M-00007i-M9 for qemu-devel@nongnu.org; Mon, 14 Sep 2009 13:08:27 -0400 Received: from [199.232.76.173] (port=42933 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnF2M-00007Q-F7 for qemu-devel@nongnu.org; Mon, 14 Sep 2009 13:08:22 -0400 Received: from mail-yx0-f203.google.com ([209.85.210.203]:62504) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MnF2L-0005WA-Rn for qemu-devel@nongnu.org; Mon, 14 Sep 2009 13:08:22 -0400 Received: by yxe41 with SMTP id 41so4545913yxe.30 for ; Mon, 14 Sep 2009 10:08:20 -0700 (PDT) Message-ID: <4AAE7880.4070406@codemonkey.ws> Date: Mon, 14 Sep 2009 12:08:16 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/12] cpuid: cleanup and some enhancements References: <1252621257-26364-1-git-send-email-andre.przywara@amd.com> In-Reply-To: <1252621257-26364-1-git-send-email-andre.przywara@amd.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andre Przywara Cc: qemu-devel@nongnu.org Andre Przywara wrote: > Hi, > > the following patchset cleans up CPUID bit handling and adds some smaller > features. > The most prominent change is to move all CPUID related functions to a > separate file. About 40% of helper.c was actually CPUID related, so say > hello to cpuid.c. While at it, I fixed some formatting issues. (Patch 1-5) > Patch 6 & 7 add the CPUID feature flag names to the output of -cpu ?. > Patch 8 & 9 simplify some code. > Patch 10 allows more CPUID leafs to be propagated to guests when -cpu host > is used, this should now reflect the host CPU's cache size. > Patch 11 adds a trimming feature (similar to KVM) to QEMU/TCG. The goal > is to describe CPU models more precisely by reflecting the feature bits of > the real hardware. Features that QEMU does not support are then masked. > If we add features to QEMU, we only need to adjust it in one location. > I will send a patch fixing the CPU models later. > Patch 12 adjusts the size of the L2 cache described by leaf 4 to a more > conservative value of one megabyte. This prevents guests assuming too large > caches if they use optimized algorithms. > This series breaks the build for non-i386 targets as it unconditionally adds cpuid.o to libqemu even though that file only exists for target-i386. Regards, Anthony Liguori > Please review, comment and apply! > Thanks and Regards, > Andre. > >