From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MnSWC-0005tj-Eq
	for qemu-devel@nongnu.org; Tue, 15 Sep 2009 03:32:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MnSW8-0005sH-QN
	for qemu-devel@nongnu.org; Tue, 15 Sep 2009 03:32:04 -0400
Received: from [199.232.76.173] (port=40899 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MnSW8-0005sD-OW
	for qemu-devel@nongnu.org; Tue, 15 Sep 2009 03:32:00 -0400
Received: from mx20.gnu.org ([199.232.41.8]:17541)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <john.cooper@redhat.com>)
	id 1MnSW8-0005rF-9a
	for qemu-devel@nongnu.org; Tue, 15 Sep 2009 03:32:00 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <john.cooper@redhat.com>) id 1MnSW6-0000JV-N6
	for qemu-devel@nongnu.org; Tue, 15 Sep 2009 03:31:59 -0400
Message-ID: <4AAF4242.10403@redhat.com>
Date: Tue, 15 Sep 2009 03:29:06 -0400
From: john cooper <john.cooper@redhat.com>
MIME-Version: 1.0
References: <20090907181436.GA8538@redhat.com> <4AA60A58.4090703@redhat.com>
	<20090914113958.GA14238@redhat.com>
In-Reply-To: <20090914113958.GA14238@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] qemu: make virtio-blk PCI compliant by
	default
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: john.cooper@redhat.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org, jens.axboe@oracle.com

Michael S. Tsirkin wrote:

> For now, what my patch does is fix the PCI compliance issue for everyone
> who uses the default setup (without the serial #). With serial disabled,
> we should not reserve any space in region 0 (not even 20 bytes).
> 
> So I propose we apply this patch for now, and then your patch only has
> to handle the case of serial number enabled. Makes sense?  If yes pls
> ack.

Sorry, I intended to do so in my previous mail.
Looks fine, ACK.

-john

-- 
john.cooper@redhat.com