From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MnZRr-0004n1-VN
	for qemu-devel@nongnu.org; Tue, 15 Sep 2009 10:56:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MnZRm-0004kw-Pm
	for qemu-devel@nongnu.org; Tue, 15 Sep 2009 10:56:03 -0400
Received: from [199.232.76.173] (port=33588 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MnZRm-0004ks-KO
	for qemu-devel@nongnu.org; Tue, 15 Sep 2009 10:55:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8080)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MnZRm-0007i4-3Q
	for qemu-devel@nongnu.org; Tue, 15 Sep 2009 10:55:58 -0400
Message-ID: <4AAFAAD9.3060308@redhat.com>
Date: Tue, 15 Sep 2009 16:55:21 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1253025151.git.mst@redhat.com>
	<20090915143319.GB24708@redhat.com>
In-Reply-To: <20090915143319.GB24708@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/2] qemu/qdev: type safety in reset handler
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Carsten Otte <cotte@de.ibm.com>, markmc@redhat.com, qemu-devel@nongnu.org, Christian Borntraeger <borntraeger@de.ibm.com>, Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>

On 09/15/09 16:33, Michael S. Tsirkin wrote:
> Add type safety to qdev reset handlers, by declaring them as
> DeviceState * rather than void *.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>

Nice.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd