From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnZzN-0007DT-1D for qemu-devel@nongnu.org; Tue, 15 Sep 2009 11:30:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnZzI-0007D0-4E for qemu-devel@nongnu.org; Tue, 15 Sep 2009 11:30:40 -0400 Received: from [199.232.76.173] (port=41175 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnZzH-0007Cx-Uc for qemu-devel@nongnu.org; Tue, 15 Sep 2009 11:30:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14972) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MnZzH-0006ki-J4 for qemu-devel@nongnu.org; Tue, 15 Sep 2009 11:30:35 -0400 Message-ID: <4AAFB2FE.1030103@redhat.com> Date: Tue, 15 Sep 2009 17:30:06 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <20090915143352.GC24708@redhat.com> In-Reply-To: <20090915143352.GC24708@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/2] qemu/virtio: fix reset with device removal List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Carsten Otte , markmc@redhat.com, qemu-devel@nongnu.org, Christian Borntraeger , Paul Brook , Avi Kivity On 09/15/09 16:33, Michael S. Tsirkin wrote: > virtio pci registers its own reset handler, but fails to unregister it, > which will lead to crashes after device removal. Solve this problem by > switching to qdev reset handler, which is automatically unregistered. Looks good. Acked-by: Gerd Hoffmann cheers, Gerd