From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoErc-0001Io-4Q for qemu-devel@nongnu.org; Thu, 17 Sep 2009 07:09:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoErW-0001BL-Jf for qemu-devel@nongnu.org; Thu, 17 Sep 2009 07:09:23 -0400 Received: from [199.232.76.173] (port=41037 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoErW-0001BD-GK for qemu-devel@nongnu.org; Thu, 17 Sep 2009 07:09:18 -0400 Received: from mail-ew0-f221.google.com ([209.85.219.221]:33459) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MoErW-0000jT-0c for qemu-devel@nongnu.org; Thu, 17 Sep 2009 07:09:18 -0400 Received: by ewy21 with SMTP id 21so265852ewy.8 for ; Thu, 17 Sep 2009 04:09:16 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4AB218DA.7010703@gnu.org> Date: Thu, 17 Sep 2009 13:09:14 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1253132733-10409-1-git-send-email-kraxel@redhat.com> <1253132733-10409-2-git-send-email-kraxel@redhat.com> <4AB1DA1C.501@gnu.org> <4AB1EA90.6080409@redhat.com> In-Reply-To: <4AB1EA90.6080409@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/7] allow qdev busses allocations be inplace List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 09/17/2009 09:51 AM, Gerd Hoffmann wrote: > On 09/17/09 08:41, Paolo Bonzini wrote: >> On 09/16/2009 10:25 PM, Gerd Hoffmann wrote: >>> +void qbus_create_inplace(BusState *bus, BusInfo *info, >> >> qbus_init? > > I'd prefer to keep it named simliar to the allocating version to avoid > confusion ... Yeah, since you're going to destroy both of them with the same function it makes sense. Paolo