* [Qemu-devel] [PATCH] kvm: Fix guest single-stepping
@ 2009-09-17 18:05 Jan Kiszka
0 siblings, 0 replies; only message in thread
From: Jan Kiszka @ 2009-09-17 18:05 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Avi Kivity, qemu-devel
Hopefully the last regression of 4c0960c0: KVM_SET_GUEST_DEBUG requires
properly synchronized guest registers (on x86: eflags) on entry.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
kvm-all.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 3c37dd7..6142e3f 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -942,7 +942,13 @@ struct kvm_set_guest_debug_data {
static void kvm_invoke_set_guest_debug(void *data)
{
struct kvm_set_guest_debug_data *dbg_data = data;
- dbg_data->err = kvm_vcpu_ioctl(dbg_data->env, KVM_SET_GUEST_DEBUG, &dbg_data->dbg);
+ CPUState *env = dbg_data->env;
+
+ if (env->kvm_state->regs_modified) {
+ kvm_arch_put_registers(env);
+ env->kvm_state->regs_modified = 0;
+ }
+ dbg_data->err = kvm_vcpu_ioctl(env, KVM_SET_GUEST_DEBUG, &dbg_data->dbg);
}
int kvm_update_guest_debug(CPUState *env, unsigned long reinject_trap)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-09-17 18:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-17 18:05 [Qemu-devel] [PATCH] kvm: Fix guest single-stepping Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).