From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MofEM-0000qD-NH
	for qemu-devel@nongnu.org; Fri, 18 Sep 2009 11:18:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MofEJ-0000nJ-1m
	for qemu-devel@nongnu.org; Fri, 18 Sep 2009 11:18:38 -0400
Received: from [199.232.76.173] (port=58530 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MofEI-0000nE-OM
	for qemu-devel@nongnu.org; Fri, 18 Sep 2009 11:18:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26011)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MofEH-0002Wj-O6
	for qemu-devel@nongnu.org; Fri, 18 Sep 2009 11:18:34 -0400
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8IFIX5r030164
	for <qemu-devel@nongnu.org>; Fri, 18 Sep 2009 11:18:33 -0400
Message-ID: <4AB3A4C6.9090001@redhat.com>
Date: Fri, 18 Sep 2009 17:18:30 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/5] serial: convert isa to qdev
References: <1253132744-10492-1-git-send-email-kraxel@redhat.com>	<1253132744-10492-5-git-send-email-kraxel@redhat.com>
	<877hvw47ll.fsf@pike.pond.sub.org>
In-Reply-To: <877hvw47ll.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On 09/18/09 17:04, Markus Armbruster wrote:
> Gerd Hoffmann<kraxel@redhat.com>  writes:
>
>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>> ---
>>   hw/mips_malta.c |    4 +-
>>   hw/mips_r4k.c   |    6 +---
>>   hw/pc.c         |    6 +---
>>   hw/pc.h         |    1 +
>>   hw/ppc_prep.c   |    3 +-
>>   hw/serial.c     |   77 +++++++++++++++++++++++++++++++++++++++++++++++-------
>>   hw/sun4u.c      |    6 +---
>>   7 files changed, 75 insertions(+), 28 deletions(-)
>
> Stupid question: how did you figure out which serials are ISA?

Look at I/O ports + irq windup.

>> +    s->baudbase = 115200;
>
> The initial baudbase.  Used to be defined as argument to serial_init(),
> but all arguments were 115200.  Okay.

Yea.  Was a bit sloppy with commit messages on this series, guess it 
needs a respin just because of that ...

cheers,
   Gerd