From: Stefan Weil <weil@mail.berlios.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] eepro100: Fix format strings in debug messages
Date: Sat, 19 Sep 2009 12:55:29 +0200 [thread overview]
Message-ID: <4AB4B8A1.5060507@mail.berlios.de> (raw)
In-Reply-To: <20090919104853.GA6764@1und1.de>
Reimar Döffinger schrieb:
> On Sat, Sep 19, 2009 at 12:37:51PM +0200, Stefan Weil wrote:
>
>> size_t arguments need %zu instead of %d.
>>
>> This patch is a step to synchronize my maintainer version
>> of eepro100.c (git://repo.or.cz/qemu/ar7.git) with the
>> version integrated in QEMU.
>>
>
> MinGW probably won't know about "zu". Casting size to uint64_t and using
> PRIu64 would be an option, as well as just ignoring MinGW.
>
Yes, this is a well known problem (a lot of QEMU code uses %zu or %zd).
Ignoring MinGW is probably the best solution here because only debugging
code is concerned. The problem will disappear as soon as Windows
provides a better printf family :-)
Regards
Stefan
prev parent reply other threads:[~2009-09-19 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-19 10:37 [Qemu-devel] [PATCH] eepro100: Fix format strings in debug messages Stefan Weil
2009-09-19 10:48 ` Reimar Döffinger
2009-09-19 10:55 ` Stefan Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB4B8A1.5060507@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).