From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MoxbP-0006IF-Rx
	for qemu-devel@nongnu.org; Sat, 19 Sep 2009 06:55:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MoxbK-0006Hs-Lr
	for qemu-devel@nongnu.org; Sat, 19 Sep 2009 06:55:38 -0400
Received: from [199.232.76.173] (port=60762 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MoxbK-0006Hp-7H
	for qemu-devel@nongnu.org; Sat, 19 Sep 2009 06:55:34 -0400
Received: from moutng.kundenserver.de ([212.227.17.8]:52401)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1MoxbJ-0006z2-Lr
	for qemu-devel@nongnu.org; Sat, 19 Sep 2009 06:55:34 -0400
Received: from localhost ([127.0.0.1] ident=stefan)
	by flocke.weilnetz.de with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1MoxbF-0002fS-Bp
	for qemu-devel@nongnu.org; Sat, 19 Sep 2009 12:55:29 +0200
Message-ID: <4AB4B8A1.5060507@mail.berlios.de>
Date: Sat, 19 Sep 2009 12:55:29 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] eepro100: Fix format strings in debug
	messages
References: <1253356671-10088-1-git-send-email-weil@mail.berlios.de>
	<20090919104853.GA6764@1und1.de>
In-Reply-To: <20090919104853.GA6764@1und1.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Reimar Döffinger schrieb:
> On Sat, Sep 19, 2009 at 12:37:51PM +0200, Stefan Weil wrote:
>   
>> size_t arguments need %zu instead of %d.
>>
>> This patch is a step to synchronize my maintainer version
>> of eepro100.c (git://repo.or.cz/qemu/ar7.git) with the
>> version integrated in QEMU.
>>     
>
> MinGW probably won't know about "zu". Casting size to uint64_t and using
> PRIu64 would be an option, as well as just ignoring MinGW.
>   

Yes, this is a well known problem (a lot of QEMU code uses %zu or %zd).

Ignoring MinGW is probably the best solution here because only debugging
code is concerned. The problem will disappear as soon as Windows
provides a better printf family :-)

Regards
Stefan