From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mpdir-0001MY-AJ
	for qemu-devel@nongnu.org; Mon, 21 Sep 2009 03:54:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mpdim-0001EN-LG
	for qemu-devel@nongnu.org; Mon, 21 Sep 2009 03:54:08 -0400
Received: from [199.232.76.173] (port=54071 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mpdim-0001Dz-94
	for qemu-devel@nongnu.org; Mon, 21 Sep 2009 03:54:04 -0400
Received: from mx20.gnu.org ([199.232.41.8]:39704)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1Mpdil-0002IL-FC
	for qemu-devel@nongnu.org; Mon, 21 Sep 2009 03:54:03 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mpdik-0007us-Ip
	for qemu-devel@nongnu.org; Mon, 21 Sep 2009 03:54:02 -0400
Message-ID: <4AB73114.4050508@redhat.com>
Date: Mon, 21 Sep 2009 09:53:56 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/4] SCSI-Hotdel: Implement drive_hot_del
References: <1253287594-12905-1-git-send-email-wolfgang.mauerer@siemens.com>	<1253287594-12905-2-git-send-email-wolfgang.mauerer@siemens.com>	<1253287594-12905-3-git-send-email-wolfgang.mauerer@siemens.com>
	<1253287594-12905-4-git-send-email-wolfgang.mauerer@siemens.com>
In-Reply-To: <1253287594-12905-4-git-send-email-wolfgang.mauerer@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, wlm.libvirt@googlemail.com

   Hi,

> +     dinfo = drive_get(type, bus, unit);
> +     if (!dinfo) {
> +         monitor_printf(mon, "Trying to remove non-existent device\n");
> +	 return;
> +     }

No.  Just don't do this silly if/bus/unit parsing.  At very minimum use 
drive_get_by_id() here, then have something like 'drive_del $id'.

IMHO much better would be to go qdev instead though.  We should have 
generic device_add + device_del monitor commands which work for any 
device, pretty much like the -device command line switch.

cheers,
   Gerd