From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mq1hd-00047i-IF for qemu-devel@nongnu.org; Tue, 22 Sep 2009 05:30:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mq1hY-00043V-Rt for qemu-devel@nongnu.org; Tue, 22 Sep 2009 05:30:29 -0400 Received: from [199.232.76.173] (port=34992 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mq1hY-00043M-O3 for qemu-devel@nongnu.org; Tue, 22 Sep 2009 05:30:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15443) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mq1hX-0008Es-Qy for qemu-devel@nongnu.org; Tue, 22 Sep 2009 05:30:24 -0400 Message-ID: <4AB8992B.7070709@redhat.com> Date: Tue, 22 Sep 2009 12:30:19 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] qemu: make virtio-blk PCI compliant by default References: <20090907181436.GA8538@redhat.com> <4AA60A58.4090703@redhat.com> <20090908075831.GA9875@redhat.com> <200909212039.01126.rusty@rustcorp.com.au> <4AB7A01A.3000206@redhat.com> In-Reply-To: <4AB7A01A.3000206@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: john cooper Cc: Rusty Russell , "Michael S. Tsirkin" , qemu-devel@nongnu.org, jens.axboe@oracle.com On 09/21/2009 06:47 PM, john cooper wrote: > Rusty Russell wrote: > > >> Too late, but no big deal. We just add another feature bit for the >> new method. We can have a command virtqueue for queries such as this. >> >> (Interestingly, this same issue broke lguest, with the 8-bit limit on >> configuration space sizes). >> > I believe the existing guest visible interface > is preservable as-is without introducing any > ATA specific knowledge into the driver. A > trivial alternate R/O mapping for the page > into the guest is all that is required. > > I ran out of time last week to tie this off > but hopefully will do so shortly. > > Can we just read this page as a virtqueue command instead of having it mapped permanently? -- error compiling committee.c: too many arguments to function