From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/5] floppy: move dma setup + drive connect to fdctrl_init_common()
Date: Tue, 22 Sep 2009 19:41:51 +0200 [thread overview]
Message-ID: <4AB90C5F.10008@reactos.org> (raw)
In-Reply-To: <1253620402-18682-3-git-send-email-kraxel@redhat.com>
Hi,
Gerd Hoffmann a écrit :
> isa-fdc is completely qdev-ified with this patch applied, all
> configuration uses properties.
>
> sysbus-fdc needs dma_channel config fixed. There is only one user
> (mips_jazz) which uses dma channel 0. Can anyone knowing this
> platform suggest how to deal with it? Is hardcoding fine?
>
>
MIPS Jazz floppy drive should not be connected to ISA DMA, but to Jazz
DMA. Unfortunately, atm, floppy emulation is too tied to isa dma
controller to be able to do this (like esp which gets dma read/write
function pointers)...
Either you can change floppy to handle other dma engines, or you can
hardcode the dma channel to whatever you want (will be wrong in all
cases). I simply ask you to keep dma enabled.
Hervé
next prev parent reply other threads:[~2009-09-22 17:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 11:53 [Qemu-devel] [PATCH 0/5] isa: more qdev conversions Gerd Hoffmann
2009-09-22 11:53 ` [Qemu-devel] [PATCH 1/5] floppy: add drive properties Gerd Hoffmann
2009-09-22 11:53 ` [Qemu-devel] [PATCH 2/5] floppy: move dma setup + drive connect to fdctrl_init_common() Gerd Hoffmann
2009-09-22 17:41 ` Hervé Poussineau [this message]
2009-09-22 11:53 ` [Qemu-devel] [PATCH 3/5] qdev: don't crash on unset drive properties Gerd Hoffmann
2009-09-22 11:53 ` [Qemu-devel] [PATCH 4/5] serial: convert isa to qdev Gerd Hoffmann
2009-09-23 20:42 ` Markus Armbruster
2009-09-22 11:53 ` [Qemu-devel] [PATCH 5/5] parallel: " Gerd Hoffmann
2009-09-23 20:44 ` [Qemu-devel] [PATCH 0/5] isa: more qdev conversions Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2009-09-16 20:25 Gerd Hoffmann
2009-09-16 20:25 ` [Qemu-devel] [PATCH 2/5] floppy: move dma setup + drive connect to fdctrl_init_common() Gerd Hoffmann
2009-09-18 14:48 ` Markus Armbruster
2009-09-18 14:58 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB90C5F.10008@reactos.org \
--to=hpoussin@reactos.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).