From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mq9NM-0003nu-On
	for qemu-devel@nongnu.org; Tue, 22 Sep 2009 13:42:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mq9NH-0003mc-83
	for qemu-devel@nongnu.org; Tue, 22 Sep 2009 13:42:03 -0400
Received: from [199.232.76.173] (port=57810 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mq9NH-0003mZ-3R
	for qemu-devel@nongnu.org; Tue, 22 Sep 2009 13:41:59 -0400
Received: from smtp3-g21.free.fr ([212.27.42.3]:34273)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <hpoussin@reactos.org>) id 1Mq9NG-00007C-D2
	for qemu-devel@nongnu.org; Tue, 22 Sep 2009 13:41:58 -0400
Message-ID: <4AB90C5F.10008@reactos.org>
Date: Tue, 22 Sep 2009 19:41:51 +0200
From: =?ISO-8859-1?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/5] floppy: move dma setup + drive connect
	to	fdctrl_init_common()
References: <1253620402-18682-1-git-send-email-kraxel@redhat.com>
	<1253620402-18682-3-git-send-email-kraxel@redhat.com>
In-Reply-To: <1253620402-18682-3-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Hi,

Gerd Hoffmann a =E9crit :
> isa-fdc is completely qdev-ified with this patch applied, all
> configuration uses properties.
>
> sysbus-fdc needs dma_channel config fixed.  There is only one user
> (mips_jazz) which uses dma channel 0.  Can anyone knowing this
> platform suggest how to deal with it?  Is hardcoding fine?
>
>  =20

MIPS Jazz floppy drive should not be connected to ISA DMA, but to Jazz=20
DMA. Unfortunately, atm, floppy emulation is too tied to isa dma=20
controller to be able to do this (like esp which gets dma read/write=20
function pointers)...
Either you can change floppy to handle other dma engines, or you can=20
hardcode the dma channel to whatever you want (will be wrong in all=20
cases). I simply ask you to keep dma enabled.

Herv=E9