qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] virtio-console: Add support for	multiple ports for generic guest-host communication
Date: Wed, 23 Sep 2009 15:04:27 +0200	[thread overview]
Message-ID: <4ABA1CDB.7080209@redhat.com> (raw)
In-Reply-To: <20090923124032.GA31933@amit-x200.redhat.com>

>> -device virtio-console
>>     Creates the portbus master.  No ports (yet).
>>
>> -device vmport-console,chardev=$dev
>>     Creates a port named 'org.qemu.console' and links it to $dev.
>
> OK; that's what I have now, slightly different:
>
> -device virtio-console-pci -device virtconport,port=0,chardev=$dev

Fine as well.  The exact names don't really matter, the naming for the 
port drivers should be consistent though (i.e. have the same prefix for 
all of them or something like that).  Optional port number looks 
reasonable too.  Should default to auto-allocation if not specified.

>> For backward-compatibility we'll allways have to create a vmport-console
>> at port 0, so there will never be a virtio-console without a port.  That
>> is a minor bit we can fixup once the above works fine.
>
> ie -virtioconsole<chardev>  ?

There are two kinds of backward compatibility ;)  One is the qemu 
command line.  The other is the ABI for old guest drivers.  The later 
requires a console at port 0 ...

> I'd suggest we just drop that in 0.12.

Dropping the command line switch is with me.  In case someone disagrees 
(libvirt folks?) it isn't hard to maintain compatibility though.

cheers,
   Gerd

  reply	other threads:[~2009-09-23 13:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22 16:23 [Qemu-devel] Multiple port support for virtio-console Amit Shah
2009-09-22 16:23 ` [Qemu-devel] [PATCH 1/4] char: Emit 'OPENED' events on char device open Amit Shah
2009-09-22 16:23   ` [Qemu-devel] [PATCH 2/4] qdev: add string property Amit Shah
2009-09-22 16:23     ` [Qemu-devel] [PATCH 3/4] virtio-console: Add support for multiple ports for generic guest-host communication Amit Shah
2009-09-22 16:23       ` [Qemu-devel] [PATCH 4/4] virtio-console: Add a in-qemu api for open/read/write/close ports Amit Shah
2009-09-23  9:12         ` Gerd Hoffmann
2009-09-23  9:07       ` [Qemu-devel] [PATCH 3/4] virtio-console: Add support for multiple ports for generic guest-host communication Gerd Hoffmann
2009-09-23  9:43         ` Amit Shah
2009-09-23 11:20           ` Gerd Hoffmann
2009-09-23 11:50             ` Amit Shah
2009-09-23 12:30               ` Gerd Hoffmann
2009-09-23 12:40                 ` Amit Shah
2009-09-23 13:04                   ` Gerd Hoffmann [this message]
2009-09-23 13:17                     ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABA1CDB.7080209@redhat.com \
    --to=kraxel@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).