From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqRWS-0001T6-Rn for qemu-devel@nongnu.org; Wed, 23 Sep 2009 09:04:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqRWL-0001Rz-D5 for qemu-devel@nongnu.org; Wed, 23 Sep 2009 09:04:39 -0400 Received: from [199.232.76.173] (port=49350 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqRWK-0001Rl-1d for qemu-devel@nongnu.org; Wed, 23 Sep 2009 09:04:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28157) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqRWJ-0003Jv-EK for qemu-devel@nongnu.org; Wed, 23 Sep 2009 09:04:31 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8ND4UWg030173 for ; Wed, 23 Sep 2009 09:04:30 -0400 Message-ID: <4ABA1CDB.7080209@redhat.com> Date: Wed, 23 Sep 2009 15:04:27 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/4] virtio-console: Add support for multiple ports for generic guest-host communication References: <1253636627-12746-1-git-send-email-amit.shah@redhat.com> <1253636627-12746-2-git-send-email-amit.shah@redhat.com> <1253636627-12746-3-git-send-email-amit.shah@redhat.com> <1253636627-12746-4-git-send-email-amit.shah@redhat.com> <4AB9E536.4050001@redhat.com> <20090923094340.GA27483@amit-x200.redhat.com> <4ABA0481.6090603@redhat.com> <20090923115043.GA28088@amit-x200.redhat.com> <4ABA14EF.2050703@redhat.com> <20090923124032.GA31933@amit-x200.redhat.com> In-Reply-To: <20090923124032.GA31933@amit-x200.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu-devel@nongnu.org >> -device virtio-console >> Creates the portbus master. No ports (yet). >> >> -device vmport-console,chardev=$dev >> Creates a port named 'org.qemu.console' and links it to $dev. > > OK; that's what I have now, slightly different: > > -device virtio-console-pci -device virtconport,port=0,chardev=$dev Fine as well. The exact names don't really matter, the naming for the port drivers should be consistent though (i.e. have the same prefix for all of them or something like that). Optional port number looks reasonable too. Should default to auto-allocation if not specified. >> For backward-compatibility we'll allways have to create a vmport-console >> at port 0, so there will never be a virtio-console without a port. That >> is a minor bit we can fixup once the above works fine. > > ie -virtioconsole ? There are two kinds of backward compatibility ;) One is the qemu command line. The other is the ABI for old guest drivers. The later requires a console at port 0 ... > I'd suggest we just drop that in 0.12. Dropping the command line switch is with me. In case someone disagrees (libvirt folks?) it isn't hard to maintain compatibility though. cheers, Gerd