From: Anthony Liguori <anthony@codemonkey.ws>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] Re: comments on: get page size in device init
Date: Wed, 23 Sep 2009 15:35:51 -0500 [thread overview]
Message-ID: <4ABA86A7.5070304@codemonkey.ws> (raw)
In-Reply-To: <f43fc5580909231203l2b80116bi120efaa2752ca867@mail.gmail.com>
Blue Swirl wrote:
> That would work and target_get_page_size() together with
> get_ram_size() would also handle the virtio case nicely, except for
> the if (!kvm_enabled() || kvm_has_sync_mmu()) part.
>
We probably want to introduce a qemu_zero_memory_page() that includes
that check. We have the same basic check during memory loading too.
Regards,
Anthony Liguori
prev parent reply other threads:[~2009-09-23 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 12:58 [Qemu-devel] comments on: get page size in device init Michael S. Tsirkin
2009-09-23 17:07 ` [Qemu-devel] " Blue Swirl
2009-09-23 18:02 ` Anthony Liguori
2009-09-23 18:40 ` Michael S. Tsirkin
2009-09-23 19:03 ` Blue Swirl
2009-09-23 19:13 ` Michael S. Tsirkin
2009-09-23 19:59 ` Blue Swirl
2009-09-23 19:19 ` Michael S. Tsirkin
2009-09-23 20:35 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABA86A7.5070304@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).