From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqYZH-0006yj-C7
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 16:36:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqYZD-0006yS-1A
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 16:36:02 -0400
Received: from [199.232.76.173] (port=52228 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqYZC-0006yP-RP
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 16:35:58 -0400
Received: from mail-qy0-f173.google.com ([209.85.221.173]:39526)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MqYZC-0006y9-IM
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 16:35:58 -0400
Received: by qyk3 with SMTP id 3so927221qyk.4
	for <qemu-devel@nongnu.org>; Wed, 23 Sep 2009 13:35:58 -0700 (PDT)
Message-ID: <4ABA86A7.5070304@codemonkey.ws>
Date: Wed, 23 Sep 2009 15:35:51 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20090923125818.GA13875@redhat.com>
	<f43fc5580909231007q7fbad3a0ydb07e8b8e30f5603@mail.gmail.com>
	<4ABA62D0.2060205@codemonkey.ws>
	<20090923184041.GA18947@redhat.com>
	<f43fc5580909231203l2b80116bi120efaa2752ca867@mail.gmail.com>
In-Reply-To: <f43fc5580909231203l2b80116bi120efaa2752ca867@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: comments on: get page size in device init
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

Blue Swirl wrote:
> That would work and target_get_page_size() together with
> get_ram_size() would also handle the virtio case nicely, except for
> the if (!kvm_enabled() || kvm_has_sync_mmu()) part.
>   

We probably want to introduce a qemu_zero_memory_page() that includes 
that check.  We have the same basic check during memory loading too.

Regards,

Anthony Liguori