Re: [Qemu-devel] [PATCH] eepro100: Don't allow guests to fail assertions

[Kevin Wolf <kwolf@redhat.com>]

Am 23.09.2009 20:02, schrieb Stefan Weil:
> Kevin Wolf schrieb:
>> The idea of using assert() for input validation is rather questionable.
>> Let's remove it from eepro100, so that guests need to find more
>> interesting
>> ways if they want to crash qemu.
>>
>> This patch replaces asserts that are directly dependent on
>> guest-accessible
>> data by other means of error handling.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>> hw/eepro100.c | 46 +++++++++++++++++++++++++++++++++++-----------
>> 1 files changed, 35 insertions(+), 11 deletions(-)
>>
> There are about 10 pending patches for eepro100.c, so the code at
> savannah is
> not a good base for new patches of eepro100.c. And there are even more
> patches
> in my queue to be sent as soon as the first 10 are integrated.
> 
> git://repo.or.cz/qemu/ar7.git has my latest version of eepro100.c.
> Could you please send a patch based on that version (or just wait
> until the savannah version is up-to-date)?

Seems this is just what must happen when patches accumulate on the list
without being committed. I'll try to rebase on top of your patches.
Thanks for the git URL, saves me some work of applying everything manually.

Apart from that, have you had a look at the actual changes? In some
places I'm not completely sure what's the right thing to do. I just know
that assert is the wrong one.

Kevin