From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mr5AU-0007rG-A7
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 03:24:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mr5AP-0007qa-Rf
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 03:24:38 -0400
Received: from [199.232.76.173] (port=44217 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mr5AP-0007qX-PT
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 03:24:33 -0400
Received: from mx20.gnu.org ([199.232.41.8]:28373)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1Mr5AP-00061a-6e
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 03:24:33 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mr5AO-0005vi-6P
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 03:24:32 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8P7OVWT031696
	for <qemu-devel@nongnu.org>; Fri, 25 Sep 2009 03:24:31 -0400
Message-ID: <4ABC702C.3040904@redhat.com>
Date: Fri, 25 Sep 2009 09:24:28 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 07/13] piix_pci: kill PIIX3IrqState
References: <1253611767-6483-1-git-send-email-kraxel@redhat.com>	<1253611767-6483-8-git-send-email-kraxel@redhat.com>
	<87my4kb2w8.fsf@pike.pond.sub.org>
In-Reply-To: <87my4kb2w8.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

   Hi,

>> -    b = pci_register_bus(&s->busdev.qdev, "pci.0",
>> -                         piix3_set_irq, pci_slot_get_pirq, irq_state, 0, 4);
>> +    b = pci_bus_new(&s->busdev.qdev, NULL, 0);
>
> Passes null name to pci_bus_new().  Intentional?  Before, we passed
> "pci.0" to pci_register_bus().

Yes.  qbus_create() will construct a name for you, which happens to be 
"pci.0".  So we don't need to pass it in.  Having "pci.0" in there was 
just temporary needed due to the order patches where merged.

cheers,
   Gerd