From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mr5JC-0002NH-VZ
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 03:33:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mr5J8-0002DR-EQ
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 03:33:38 -0400
Received: from [199.232.76.173] (port=39518 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mr5J8-0002DG-5y
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 03:33:34 -0400
Received: from mx20.gnu.org ([199.232.41.8]:29114)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1Mr5J7-0007ge-Hs
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 03:33:33 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mr5J6-0006bW-O2
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 03:33:33 -0400
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8P7XVCp029522
	for <qemu-devel@nongnu.org>; Fri, 25 Sep 2009 03:33:31 -0400
Message-ID: <4ABC7248.3030805@redhat.com>
Date: Fri, 25 Sep 2009 09:33:28 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 09/13] Add exit callback to DeviceInfo.
References: <1253611767-6483-1-git-send-email-kraxel@redhat.com>	<1253611767-6483-10-git-send-email-kraxel@redhat.com>
	<87d45gb1ya.fsf@pike.pond.sub.org>
In-Reply-To: <87d45gb1ya.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

>>       qdev_initfn init;
>> +    qdev_exitfn exit;
>>       BusInfo *bus_info;
>>       struct DeviceInfo *next;
>>   };
>
> I don't like the name "exit".  The buddy of init() is often called
> fini().

Picked that name convention up from the linux kernel which has 
module_init() and module_exit() ...

I can change it, but I'd like to have some kind of agreement on the list 
so I don't have to go through all the patches changing this twice. 
Naming variants I can thing of are:

   * exit
   * fini
   * free
   * uninit
   * cleanup
   * release

Comments?

cheers,
   Gerd