From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mr6UB-0000qq-0l
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 04:49:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mr6U7-0000oX-0P
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 04:49:02 -0400
Received: from [199.232.76.173] (port=36202 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mr6U6-0000oU-RL
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 04:48:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13264)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mr6U6-00031P-Bt
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 04:48:58 -0400
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8P8mvLD026969
	for <qemu-devel@nongnu.org>; Fri, 25 Sep 2009 04:48:57 -0400
Message-ID: <4ABC83F6.3060901@redhat.com>
Date: Fri, 25 Sep 2009 10:48:54 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] qdev: show failing device name instead of
	silently exiting
References: <1253704471-30740-1-git-send-email-amit.shah@redhat.com>	<8763b97588.fsf@pike.pond.sub.org>
	<20090924035908.GA4584@amit-x200.redhat.com>
In-Reply-To: <20090924035908.GA4584@amit-x200.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On 09/24/09 05:59, Amit Shah wrote:
> Hey Markus,
>
> On (Wed) Sep 23 2009 [22:53:27], Markus Armbruster wrote:
>> Amit Shah<amit.shah@redhat.com>  writes:
>>
>>> If initializing a device fails, show the name of the device
>>> and then exit
>>
>> "and then exit" is misleading, as you don't add an exit.
>
> The 'return NULL' does that -- the calling function exits.
> (doesn't the subject line clarify that?)

I have patches in the queue which will wind up this via device_add 
monitor command.  Caller will *not* exit then ;)

cheers,
   Gerd