From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MsYoy-0002PY-4Y for qemu-devel@nongnu.org; Tue, 29 Sep 2009 05:16:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MsYos-0002Ov-SJ for qemu-devel@nongnu.org; Tue, 29 Sep 2009 05:16:31 -0400 Received: from [199.232.76.173] (port=34121 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MsYos-0002Oq-Jy for qemu-devel@nongnu.org; Tue, 29 Sep 2009 05:16:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58662) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MsYos-0002Q2-6f for qemu-devel@nongnu.org; Tue, 29 Sep 2009 05:16:26 -0400 Message-ID: <4AC1D064.5090606@redhat.com> Date: Tue, 29 Sep 2009 11:16:20 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4AB7A01A.3000206@redhat.com> <4AB8992B.7070709@redhat.com> <4AB8DD53.7070806@redhat.com> <4AB8DECA.3090908@redhat.com> <4AB8E88C.4040103@redhat.com> <4AB980E6.2070203@codemonkey.ws> <4AB9AA8E.7060800@third-harmonic.com> <4AC1A49A.1010308@redhat.com> <20090929065856.GC25389@redhat.com> <4AC1B5CD.7050702@redhat.com> <20090929085450.GE25389@redhat.com> In-Reply-To: <20090929085450.GE25389@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config breakage List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: john cooper , john cooper , Rusty Russell , qemu-devel@nongnu.org, Vadim Rozenfeld , jens.axboe@oracle.com On 09/29/2009 10:54 AM, Michael S. Tsirkin wrote: > On Tue, Sep 29, 2009 at 09:22:53AM +0200, Avi Kivity wrote: > >> On 09/29/2009 08:58 AM, Michael S. Tsirkin wrote: >> >>> Using bar per feature we'll quickly run out of BARs. >>> We already use a BAR for MSI-X - let's add >>> ATA identity there? >>> >>> >> Mixing unrelated features will quickly cause confusion. >> > Note if we ever switch to 64 bit BARs, we'll only have 3 of these > available, so the ID would be using the last free one. > We can just as well plan ahead for when we'll add another feature? > > I agree fixed offsets are messy though. I previously proposed storing > the offset to the identity data in an i/o register. This will let each > implementation lay out this data in an optimal manner, without > confusion. > Yes, that works much better. -- error compiling committee.c: too many arguments to function