From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MscgC-0003k7-Qj
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 09:23:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mscg8-0003fJ-T0
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 09:23:44 -0400
Received: from [199.232.76.173] (port=53586 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mscg8-0003f9-LG
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 09:23:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44217)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mscg8-0003Fy-6b
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 09:23:40 -0400
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8TDNcYB024793
	for <qemu-devel@nongnu.org>; Tue, 29 Sep 2009 09:23:39 -0400
Message-ID: <4AC20A58.7000806@redhat.com>
Date: Tue, 29 Sep 2009 15:23:36 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 16/24] qdev hotplug: infrastructure and
	monitor commands.
References: <1253907769-1067-1-git-send-email-kraxel@redhat.com>	<1253907769-1067-17-git-send-email-kraxel@redhat.com>	<87r5tqdd4c.fsf@pike.pond.sub.org>
	<4AC1CE72.5090601@redhat.com> <871vlq6ipk.fsf@pike.pond.sub.org>
In-Reply-To: <871vlq6ipk.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

   Hi,

>> I started that way.  Doesn't fly.  Not every device creation goes
>> through qdev_device_add().  Thus you'll have to do this in
>> qdev_create(), which in turn means that you would have to add a
>> hotplug parameter to tons of functions just to pass it down to
>> qdev_create ...
>
> Isn't it sufficient if every *hotplug* device creation goes through
> qdev_device_add()?

That isn't the case too.

cheers,
   Gerd